Repository navigation
chore(redis): require Redis and remove the no-Redis fallbacks - #10272
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[High impact] The PR appears safe to merge with the documented requirement that self-hosted installs provide Redis. SummaryRedis becomes required for the app and realtime service.
No new actionable issue was established. This review used source inspection; no tests were run.
|
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Confidence score: 4/5
orphaned-runs.integration.tscan still fail during teardown whenTEST_REDIS_URLis unset, even though the suite is skipped. Guard cleanup withif (redisUrl).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/mothership/async-runs/orphaned-runs.integration.ts">
<violation number="1" location="apps/sim/lib/mothership/async-runs/orphaned-runs.integration.ts:83">
P2: The skipped suite still runs this outer teardown, but `getRedisClient()` now throws when `TEST_REDIS_URL` is absent. Guard the cleanup with `if (redisUrl)` so no-Redis test runs can skip cleanly.</violation>
</file>
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
This PR changes infrastructure or deployment configuration. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
Turn on auto-fix | Re-trigger cubic
…ltime, setup and deploy config
… of the fallback removal
…ests for lazy channels
3c5fcc0 to
a696c09
Compare
Summary
REDIS_URL.next buildstill needs no Redis: pub/sub channels, MCP caches and rate-limit storage all resolve their client on first use.CACHE_CAPABILITYswitch that drove them:readyRedisClientstatus gates, isolated-vmundetermined, abortunknown,redis_write_failed, and the progress-marker SQL fallback. Hosted behavior is unchanged, because those not-configured branches never ran there.REDIS_URLas a required core key, and thecachecommand is gone.REDIS_URLsource reaches the app or realtime pods. Inline values, an existing Secret, External Secrets,extraEnvVars,realtime.envandenvDefaultsall count..env.examplefiles and the self-hosting docs now say Redis is required, with eviction-policy guidance (noeviction).rate_limit_bucketis marked contract-pending, to be dropped after this release ships.Type of Change
Testing
REDIS_URLunset, importing every module-scope rate limiter and singleton plus allapp/api/**/route.tsfiles throws no Redis error. The same check fails on the pre-fix rate limiter.type-checkclean for apps/sim and apps/realtime.helm lint,helm unittest(136), andhelm templateover every example and CI values file.check:api-validation:strict,check:unused-exports,check:test-patterns,check:utils,check:boundaries,check:client-boundary,check:deployment-config, and docs--verify-compatibility.Checklist
test-auditauthoring gate)