Skip to content

fix(executor): keep the condition-join loop test off the Redis-backed isolate lease - #10275

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/condition-join-loop-lease
Nov 21, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/condition-join-loop-lease

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Type of Change

  • Bug fix (test)

Testing

  • bun run --cwd apps/sim test executor/execution/condition-join-loop.test.ts: 2/2 pass (both failed on staging HEAD)
  • check:test-patterns, biome

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 21, 2026 4:42am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Moves the isolated-VM test doubles into one shared mock without changing production code.

  • The condition-join test now completes both loop iterations.

Reviews (2) · Last reviewed commit: "improvement(testing): share one isolated..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

This branch was previously deployed

1 inactive deployment
Preview — 145e878b Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant