Repository navigation
fix(public-shares): retry a public read when the shared file is saved mid-read - #10278
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryPublic file reads now retry up to three times when a save changes the file before delivery.
No actionable issues found.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
409 Shared file changed during the read.retryOnSharedFileRevisionChangein the public-shares application layer:Type of Change
Testing
content-sharing.integration.ts: a real save commits from inside the storage read, for both a streamed Markdown file and a rendered page.conflictafter exactly 3 writes, proving the retry is bounded.type-check;check:test-patterns,check:comment-hygiene,check:boundaries,check:source-conventions,check:explicit-any.Checklist
test-auditauthoring gate)