Skip to content

fix(docs): close the Redis client so the docs provider e2e exits - #10280

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/docs-provider-e2e-redis-close
Nov 21, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/docs-provider-e2e-redis-close

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Since Redis became required (chore(redis): require Redis and remove the no-Redis fallbacks #10272), test-docs-search-provider-e2e.ts runs the app's docs search in-process through the Redis-backed rate limiter. That opens an ioredis client and its health-check interval.
  • The script's cleanup closed Postgres but never the Redis client. So after logging "Verified docs provider and platform boundary", the process stayed alive until the job timed out and was cancelled. The docs acceptance (platform) / docs HTTP checks have failed on every staging commit since chore(redis): require Redis and remove the no-Redis fallbacks #10272.
  • Close the Redis client in the script's existing closePlatform cleanup with closeRedisConnection(), which quits the client and clears the ping interval.

Type of Change

  • Bug fix (CI)

Testing

  • type-check, biome. The fix is confirmed by CI's docs acceptance (platform) job, which needs the docs build, Postgres and Redis.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 21, 2026 8:50am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The docs provider E2E script now closes Redis during its existing platform cleanup.

  • Docs provider checks now close Redis before the script exits.

Reviews (1) · Last reviewed commit: "fix(docs): close the Redis client so the..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit a009b7c into staging Nov 21, 2026
49 checks passed

This branch was previously deployed

1 inactive deployment
Preview — b60e702b Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant