Repository navigation
fix(docs): close the Redis client so the docs provider e2e exits - #10280
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] The PR appears safe to merge. SummaryThe docs provider E2E script now closes Redis during its existing platform cleanup.
Reviews (1) · Last reviewed commit: "fix(docs): close the Redis client so the..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-docs-search-provider-e2e.tsruns the app's docs search in-process through the Redis-backed rate limiter. That opens an ioredis client and its health-check interval.docs acceptance (platform)/docs HTTPchecks have failed on every staging commit since chore(redis): require Redis and remove the no-Redis fallbacks #10272.closePlatformcleanup withcloseRedisConnection(), which quits the client and clears the ping interval.Type of Change
Testing
type-check, biome. The fix is confirmed by CI'sdocs acceptance (platform)job, which needs the docs build, Postgres and Redis.Checklist
test-auditauthoring gate)