Repository navigation
improvement(config): derive enterprise flags from one registry, add REGISTRATION_MODE, merge vLLM and LiteLLM - #10271
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[High impact] The PR appears safe to merge; the earlier concerns are addressed and no new issues were found. SummaryCentralizes enterprise settings, adds
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 97 files
This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
Turn on auto-fix | Re-trigger cubic
…rge the vLLM and LiteLLM providers
…tire the sandbox readiness marker
waleedlatif1
force-pushed
the
improvement/deployment-config-cleanup
branch
from
November 21, 2026 03:09
a857d40 to
aa8a49a
Compare
Collaborator
Author
…ment registration helpers
Collaborator
Author
This was referenced Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sim/deployment-config/enterprise-featuresholds every enterprise feature in one list. The server flags, the deployment shape sent to the browser, the API schema, the test mocks and the sim-setup unlocks all derive from it, so a feature can no longer drift between them.enterprise-entitlements.tswas checked across every flag combination.NEXT_PUBLIC_*enterprise twins are gone. The browser reads features from a server-rendered<html data-deployment-shape>attribute, so one server variable controls both the API and the UI.INBOX_ENABLED=falsenow actually turns the inbox off on billing-free deployments; before, it hid the UI while the API stayed open.ENTERPRISE_ENABLEDnow shows SSO in the browser.REGISTRATION_MODE:DISABLE_REGISTRATION,DISABLE_EMAIL_SIGNUP,EMAIL_PASSWORD_SIGNUP_ENABLEDand itsNEXT_PUBLIC_twin. Values:open(default),no-email-signup,closed,no-email,closed-no-email.NEXT_PUBLIC_EMAIL_PASSWORD_SIGNUP_ENABLED=falsenow also turns off server-side email sign-in, as documented.providers/openai-compat/self-hosted.tscore with per-provider config. Provider ids, model prefixes and env vars are unchanged..../v1becoming/v1/v1.Type of Change
Testing
type-checkis clean.check:client-boundary,check:boundaries,check:api-validation:strict,check:deployment-config,check:docs-manifest,check:test-patterns,check:unused-exports,check-explicit-any, and docs--verify-compatibility.Checklist
test-auditauthoring gate)