Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@
import net.sf.jsqlparser.statement.select.WithItem;
import net.sf.jsqlparser.statement.show.MySqlShowStatement;
import net.sf.jsqlparser.statement.show.ShowCreateStatement;
import net.sf.jsqlparser.statement.show.ShowFilter;
import net.sf.jsqlparser.statement.show.ShowIndexStatement;
import net.sf.jsqlparser.statement.show.ShowTableStatusStatement;
import net.sf.jsqlparser.statement.show.ShowTablesStatement;
Expand Down Expand Up @@ -1225,22 +1226,23 @@ public <S> Void visit(ShowStatement showStatement, S context) {

@Override
public <S> Void visit(ShowColumnsStatement showColumnsStatement, S context) {
return metadataOnly();
return metadataOnly(showColumnsStatement.getFilter());
}

@Override
public <S> Void visit(ShowIndexStatement showIndexStatement, S context) {
return metadataOnly();
metadataOnly();
return walkShowFilter(showIndexStatement.getWhereCondition());
}

@Override
public <S> Void visit(ShowTablesStatement showTables, S context) {
return metadataOnly();
return metadataOnly(showTables.getFilter());
}

@Override
public <S> Void visit(ShowTableStatusStatement showTableStatus, S context) {
return metadataOnly();
return metadataOnly(showTableStatus.getFilter());
}

@Override
Expand All @@ -1250,7 +1252,7 @@ public <S> Void visit(ShowCreateStatement showCreate, S context) {

@Override
public <S> Void visit(MySqlShowStatement mySqlShow, S context) {
return metadataOnly();
return metadataOnly(mySqlShow.getFilter());
}

@Override
Expand All @@ -1268,6 +1270,19 @@ private Void metadataOnly() {
return null;
}

private Void metadataOnly(ShowFilter filter) {
metadataOnly();
return walkShowFilter(filter == null ? null : filter.getExpression());
}

/** MySQL evaluates the LIKE or WHERE filter of a SHOW, as in SHOW TABLES WHERE f() = 0. */
private Void walkShowFilter(Expression filter) {
if (filter != null) {
filter.accept(analysis.expressions, null);
}
return null;
}

// ---- nested visitors --------------------------------------------------------------------

static final class FeatureSelectVisitor extends SelectVisitorAdapter<Void> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,12 @@ private StatementFeatures analyseAllPureExcept(String sql, String impure)
"SET @a = 1, @b = pg_read_file('x')",
"SET x = pg_read_file('x')",
"DECLARE @x INT = length(pg_read_file('x'))",
"ASSERT length(pg_read_file('x')) > 0"})
"ASSERT length(pg_read_file('x')) > 0",
"SHOW TABLES WHERE length(pg_read_file('x')) > 0",
"SHOW TABLE STATUS WHERE length(pg_read_file('x')) > 0",
"SHOW COLUMNS FROM t WHERE length(pg_read_file('x')) > 0",
"SHOW INDEX FROM t WHERE length(pg_read_file('x')) > 0",
"SHOW VARIABLES WHERE length(pg_read_file('x')) > 0"})
void functionIsChecked(String sql) throws JSQLParserException {
StatementFeatures impure = analyseAllPureExcept(sql, "pg_read_file");
assertThat(impure.getUnresolvedReferences()).containsExactly("pg_read_file");
Expand Down Expand Up @@ -781,6 +786,16 @@ void assignedSubqueryIsRead(String sql) throws JSQLParserException {
assertThat(f.returnsResultSet()).isFalse();
}

@ParameterizedTest(name = "{0}")
@ValueSource(strings = {
"SHOW TABLES WHERE Tables_in_db IN (SELECT a FROM t)",
"SHOW DATABASES WHERE (SELECT count(*) FROM t) > 0"})
void showFilterSubqueryIsRead(String sql) throws JSQLParserException {
StatementFeatures f = analyse(sql);
assertThat(f.returnsResultSet()).isTrue();
assertThat(f.is(StmtFeature.READS_DATA)).isTrue();
}

@Test
void topLevelValuesReturnsRowsWithoutReading() throws JSQLParserException {
StatementFeatures f = analyse("VALUES (1, 2)");
Expand Down
Loading