Repository navigation
fix: walk the LIKE and WHERE filters of SHOW in StatementFeatureVisitor - #2947
Merged
manticore-projects merged 1 commit intoNov 21, 2026
Merged
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatementFeatureVisitorsendsSHOW TABLES,SHOW TABLE STATUS,SHOW COLUMNS,SHOW INDEXand the MySQLSHOWstatements (DATABASES,VARIABLES,STATUS,PROCEDURE STATUS,TRIGGERS,COLLATION, ...) straight tometadataOnly(), which never looks at theirLIKE/WHEREfilter. MySQL evaluates that filter like aSELECTcondition, stored functions that write and subqueries included, soSHOW TABLES WHERE purge_audit() = 0came back ascertain=[RETURNS_RESULT_SET]withmayModifyData() == falseand no unresolved reference and passed the read-only guard in usage.rst, whileSELECT purge_audit()leavesMODIFIES_DATApossible withunresolved=[purge_audit]. A subquery there (SHOW TABLES WHERE Tables_in_db IN (SELECT a FROM t)) was not reported asREADS_DATAeither. I found it while checking which expression positions keep a function out of the purity check, next to theSET/DECLAREcases from #2935; the filters are reachable since theShowFiltermodel of #2916. The fivevisitmethods now walk the filter (getFilter(), orgetWhereCondition()forShowIndexStatement) with the expression visitor aftermetadataOnly()has claimed the top level, so a subquery there adds no second result set. The newfunctionIsCheckedandshowFilterSubqueryIsReadcases fail before (7 failures) and pass after;spotlessCheck, Checkstyle, PMD, SpotBugs andcheckGrammarAmbiguitypass, and the only other./gradlew checkfailures locally are 33 Mockito inline-mock-maker init errors in the mock-based tests and 2AccessDeniedExceptions fromParserKeywordsUtilsTestwriting its grammar temp file, both environment problems on this machine that do not touch the visitor.