Repository navigation
Conversation
…tatic check The direct Cloudflare branch re-ran strict preset detection even when the app type was configured, so a VitePress site with `routes/` and the guide's own `appType: "void"` was refused with a message telling the user to set that option.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #885
Description
resolveCloudflareStaticPresetre-ran strict SSG detection even wheninference.appTypewas configured, so the guide's own setup for a VitePress site with a backend could not pass the check that asks for that option.Detection now runs only when nothing is configured, the same condition
deploy.tsandprepareDeployArtifactuse.staticandsparesolve earlier, so a configured app type here isvoidorframework, and both mean a Worker deploy.Test
packages/void/test/unit/preset.test.tsadds the casereturns null for a configured appType "void" with an SSG plus backend, which fails without this change and passes with it.