Skip to content

fix: normalize island ID paths for Windows compatibility - #64

Merged
Brooooooklyn merged 1 commit into
mainfrom
04-01-fix_normalize_island_id_paths_for_windows_compatibility
Apr 1, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
04-01-fix_normalize_island_id_paths_for_windows_compatibility

Conversation

@shulaoda

@shulaoda shulaoda commented Apr 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Wrap relative() calls with Vite's normalizePath() when generating island IDs in all framework adapters (react, vue, solid, svelte) and the md plugin
  • On Windows, path.relative() returns backslash-separated paths (e.g. blog\_Counter), causing data-island attributes and client hydration map keys to mismatch, breaking island HMR updates

Test plan

  • Verify island component HMR updates without full page reload passes on Windows CI
  • Verify all island-related integration tests pass on both Linux and Windows

@Brooooooklyn
Brooooooklyn merged commit 71e7e03 into main Apr 1, 2026
5 of 6 checks passed
@Brooooooklyn
Brooooooklyn deleted the 04-01-fix_normalize_island_id_paths_for_windows_compatibility branch April 1, 2026 11:47
cpojer pushed a commit that referenced this pull request Sep 11, 2026
Deployments stuck in active states (pending, uploading, migrating,
prerendering) would stay there forever if the deploy handler was killed
mid-execution, since the only recovery was the stale detection at the
start of the next deploy attempt for the same project.

- Add updated_at column to deployments, set on every status transition
- Add failStaleDeployments() to the scheduled cron, auto-failing any
  deployment whose last status change was more than 30 minutes ago
- Add a 5-minute AbortSignal timeout to the migration fetch so it fails
  cleanly instead of hanging until the runtime kills the handler

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants