Repository navigation
[protobuf] proto.parse_length_prefixed can return None - #16879
Open
Primeteumm wants to merge 1 commit into
Open
Primeteumm wants to merge 1 commit into
Primeteumm wants to merge 1 commit into
Conversation
At runtime (protobuf 7.35.1, google/protobuf/proto.py), the function returns None when input_bytes is at EOF: decoder._DecodeVarint() returns None on an empty read, and parse_length_prefixed returns None in that case. Its docstring says "None if input_bytes is at EOF." and its usage example breaks out of the read loop on `if msg is None`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_length_prefixedreturnsNonewhen the input is at EOF, as its docstring says: https://github.com/protocolbuffers/protobuf/blob/v35.1/python/google/protobuf/proto.py#L79-L102Agent used: Claude Code (Claude Opus 5.5).