Repository navigation
Conversation
Cover playhouse.sqlite_ext.JSONField, playhouse.postgres_ext.ArrayField and playhouse.test_utils.count_queries, which were missing from the partial stubs. 🖇
The new playhouse extension stubs only cover a few names, so allowlist the rest and type the JSONField json_dumps/json_loads arguments. 🎂
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
reviewed
Nov 21, 2026
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Not a full review, just a few things I noticed.
Comment on lines
+13
to
+14
| *args: Any, | ||
| **kwargs: Any, |
Collaborator
There was a problem hiding this comment.
Generally, Any needs a comment explaining allowed types or how the item is used. (Field[Any] and dict[str, Any] are exceptions, since they are obvious.)
|
|
||
| from peewee import Expression, Field | ||
|
|
||
| class ArrayField(Field[list[Any]]): |
Collaborator
There was a problem hiding this comment.
Wouldn't it make more sense to make ArrayField generic over the type of the list items?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The peewee stubs are a partial stub, but
playhouse.sqlite_ext,playhouse.postgres_extandplayhouse.test_utilsare commonly used and currently resolve toAny(or fail as untyped calls under stricter checkers). This adds stubs forsqlite_ext.JSONField,postgres_ext.ArrayFieldandtest_utils.count_queries, matching the runtime implementations.Upstream: https://github.com/coleifer/peewee/blob/master/playhouse/sqlite_ext.py, https://github.com/coleifer/peewee/blob/master/playhouse/postgres_ext.py, https://github.com/coleifer/peewee/blob/master/playhouse/test_utils.py
Written with pi.