Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16837
PyYAML writes text to a binary stream when no encoding is supplied, so calls such as
yaml.safe_dump(data, BytesIO())type-check but raiseTypeError. Distinguish text writers, text writers exposingencoding, and binary writers with an explicit encoding across the dump and serialize APIs.PyYAML chooses what to write based on the presence of a stream's
encodingattribute. Python protocols cannot express that an arbitrary binary writer lacks that attribute, so the overloads cover common streams without claiming to model every custom writer. A binary writer that also exposesencodingremains a known limitation.I used AI to help investigate and implement this change.
Checks: runtime stream matrix across the six APIs, plus the matrix with both
SafeDumperandCSafeDumperfordump; mypy and Pyright; regression tests on all supported Python/platform targets; Python 3.13 stubtest; Ruff and Black on the changed files.