Skip to content

Finish incomplete modules #14031

Open
Open

Description

@srittau

These are marked with a module-level __getattr__ function with an "incomplete module" comment.

Activity

  1. added
    stubs: incompleteAnnotations or sub-modules missing from an existing package or module
    help wantedAn actionable problem of low to medium complexity where a PR would be very welcome
    on May 12, 2025
  2. donbarbos commented on Aug 21, 2025

    @donbarbos
    Contributor

    FTR: At the moment, the above condition only applies to the tensorflow stubs. The __getattr__() also appears in pygments.styles and pygments.lexers, but there it’s just a way to skip unnecessary things according to comments. As for the other functions, they are class methods

  3. KritinRane commented on Jun 8, 2026

    @KritinRane

    Hi! I'm interested in working on this as part of an open source contribution course. I'd like to pick one of the incomplete modules to complete -- is there a particular one you'd recommend for a first-time contributor, or should I just grab whichever looks smallest?

  4. brianschubert commented on Jun 8, 2026

    @brianschubert
    Collaborator

    Hi @KritinRane! Thanks for your interest in contributing to typeshed :-)

    At a glance I don't think the remaining modules with module-level __getattr__ are particularly approachable (see donbarbos' comment above). But that's just the modules that are missing public symbols. We have many stubs that are incomplete in other ways (e.g. missing entire modules, or have incomplete or missing annotations).

    A few things you can look for to find incomplete stubs:

    • annotations that use Incomplete
    • modules listed in pyrightconfig.stricter.json (which generally have unannotated items)
    • stubs with partial-stub = true or ignore-missing-stub = true in their METADATA.toml file (which are missing some modules or public symbols)

    Feel free to work on any stubs that interest you.

    Cheers!

  5. hendo-21 commented on Nov 2, 2026

    @hendo-21
    Contributor

    Hi @brianschubert!

    I'm new to typeshed I thought this could be a good first issue.

    I took your recommendation to look for annotations that use Incomplete and found some in stubs/networkx/networkx/algorithms/tree/mst.pyi, stubs/networkx/networkx/algorithms/core.pyi and stubs/networkx/networkx/algorithms/operators/unary.pyi that seem to have a straightforward fix. For example, I expect minimum_spanning_tree(G: Graph[_Node]...) -> Graph[Incomplete] should return Graph[_Node] because the function builds the MST T from G's nodes. I did some work with networkx for a graph theory course last term so I think this would be a great fit for me.

    My next step will be to review the networkx source code and confirm that each function builds its return graph from G, so I can apply Graph[_Node] in each case. I see there is an open stubsabot bump (#16424) that touches mst.pyi, but changes only the keys default in boruvka_mst_edges, not the Graph[Incomplete] returns, so I don't expect this to conflict.

    Since you mentioned the remaining __getattr__ issues aren't particularly approachable, I'll plan on opening a PR and referencing your comment there. Does that work for you?

  6. JelleZijlstra commented on Nov 4, 2026

    @JelleZijlstra
    Member

    Feel free to go ahead and open a PR!

  7. hendo-21 commented on Nov 7, 2026

    @hendo-21
    Contributor

    Feel free to go ahead and open a PR!

    Thanks! Just opened #16729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedAn actionable problem of low to medium complexity where a PR would be very welcomestubs: incompleteAnnotations or sub-modules missing from an existing package or module

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions