Repository navigation
[3.14] gh-162246: Fix lost writes on BufferedRWPair dealloc (GH-162295) - #162345
Merged
Merged
Conversation
…ythonGH-162295) `socket.makefile("rwb")` passes the same raw stream to both sides of a `BufferedRWPair`. When the pair is deallocated, the reader closes the stream before the writer can flush its buffer. Release the writer first, matching the order in `BufferedRWPair.close()`. (cherry picked from commit dc222c8) Co-authored-by: Maurycy Pawłowski-Wieroński <maurycy@maurycy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
socket.makefile("rwb")passes the same raw stream to both sides of aBufferedRWPair. When the pair is deallocated, the reader closes the stream before the writer can flush its buffer.Release the writer first, matching the order in
BufferedRWPair.close().(cherry picked from commit dc222c8)
Co-authored-by: Maurycy Pawłowski-Wieroński maurycy@maurycy.com
🤖 Generated with Claude Code