Skip to content

test: fix vfs-addon-sequence failing when TMPDIR mounted with noexec - #67566

Open
LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-vfs-tmp-noexec
Open

LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-vfs-tmp-noexec

Conversation

@LiviaMedeiros

Copy link
Copy Markdown
Member

This test consistently fails on any system having /tmp mounted with noexec flag.

AssertionError [ERR_ASSERTION]: node:internal/vfs/setup:1128
      return dlopenBinary(module, filename, flags, readFileSync(filename));
             ^

Error: could not create a temporary directory for the native addon: /dev/null/vfs/1/function.node
    at process.dlopen (node:internal/vfs/setup:1128:14)
    at Object..node (node:internal/modules/cjs/loader:2135:18)
    at Module.load (node:internal/modules/cjs/loader:1690:32)
    at Module._load (node:internal/modules/cjs/loader:1480:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:261:19)
    at Module.require (node:internal/modules/cjs/loader:1713:12)
    at require (node:internal/modules/helpers:332:16)
    at [eval]:11:26
    at runScriptInThisContext (node:internal/vm:219:10)
    at node:internal/process/execution:485:12 {
  code: 'ERR_DLOPEN_FAILED'
}

Changing env.TMPDIR makes it pass, didn't investigate further.

Signed-off-by: LiviaMedeiros <livia@cirno.name>
@LiviaMedeiros LiviaMedeiros added test Issues and PRs related to Node.js core tests and test infrastructure. vfs Issues and PRs related to the virtual filesystem subsystem. labels Nov 18, 2026
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 18, 2026
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (1727b13) to head (b3329ee).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67566      +/-   ##
==========================================
+ Coverage   90.67%   90.71%   +0.03%     
==========================================
  Files         800      801       +1     
  Lines      281001   280705     -296     
  Branches    54286    54175     -111     
==========================================
- Hits       254797   254636     -161     
+ Misses      16295    16257      -38     
+ Partials     9909     9812      -97     

see 66 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants