Repository navigation
Reject non-Proc callbacks in Packer#register_type_internal - #413
Closed
eightbitraptor wants to merge 1 commit into
Closed
eightbitraptor wants to merge 1 commit into
eightbitraptor wants to merge 1 commit into
Conversation
the Packer invokes callbacks with rb_proc_call_with_block which doesn't do any type checking that the proc is actually a proc, so it's possible for an oject that's not a proc to reach rb_vm_invoke_proc and be treated as an rb_proc_t. This commit adds a type check and raise to register_type_internal.
Member
|
Thanks, the JRuby version need updating too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the Packer invokes callbacks with rb_proc_call_with_block which doesn't do any type checking that the proc is actually a proc, so it's possible for an oject that's not a proc to reach rb_vm_invoke_proc and be treated as an rb_proc_t.
This commit adds a type check and raise to register_type_internal.