You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The schema now accepts negative original ranges for expect directives that normalization rejects, allowing schema-valid mapper output to fail transformation.
InitializeParams and handshake still omit capabilities.diagnosticDirectiveCodeSelectors, so a mapper following #65516's negotiation contract will never emit these selected ignores. Sending them unconditionally is unsafe because the previous host interprets a six-element ignore tuple as range-only suppression, hiding unrelated diagnostics. Add the capability to the initialization schema/generated type, advertise it in hostimpl.go's handshake, and test that advertisement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #65517 with my review suggestions applied.
Closes #65516