Repository navigation
Quota VM_DISK tariff calculation - #7152
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7152 +/- ##
============================================
+ Coverage 11.79% 12.63% +0.83%
- Complexity 7692 8610 +918
============================================
Files 2511 2711 +200
Lines 246578 255748 +9170
Branches 38446 39871 +1425
============================================
+ Hits 29090 32312 +3222
- Misses 213703 219337 +5634
- Partials 3785 4099 +314
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm,
Is there any compelling reason to have this included in 4.18, @BryanMLima @GutoVeronezi , as the custom quota tarrifs is also part of 4.18?
@DaanHoogland, previously to introducing the custom quota tariffs, those usage types already were not calculated:
It would be good to have this in 4.18; however, I do not see it as mandatory. In the worst case, nothing changes to the final user. |
yadvr
left a comment
There was a problem hiding this comment.
Didn't test it but changes LGTM.
GutoVeronezi
left a comment
There was a problem hiding this comment.
CLGTM
@BryanMLima, I pointed out a minor adjust in the comment in SQL.
|
@GutoVeronezi cc @BryanMLima , I am happy to include this in 4.18, especially as the unit test is adjusted to include this and the risk for other features is minimal. Is there any more automated testing that could be added for this? |
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
|
@DaanHoogland cc @GutoVeronezi Thanks for adding to version |
|
Kudos, SonarCloud Quality Gate passed! |








Description
Currently, the quota plugin ignores the tariff calculation for the types below:
The code was changed as to now calculate the quota tariff for these types. Moreover, the unit types were changed as well, as shown in the table below. It is noteworthy that the raw values for these types are not modified; therefore, the calculation of the tariff for them are:
TARIFF * CONSUMPTION.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
This was tested in a local lab creating a quota tariff for each type. Then, I reinstalled a previously created VM and generated a quota statement.
Creating a quota tariff with type
VM_DISK_IO_READ: