Repository navigation
Restart the KVM agent with sudo when the host user is not root - #14741
Open
bhouse-nexthop wants to merge 1 commit into
Open
bhouse-nexthop wants to merge 1 commit into
bhouse-nexthop wants to merge 1 commit into
Conversation
cancelHostMaintenance on a KVM host whose agent is not Up restarts the agent over SSH (kvm.ssh.to.agent=true). It ran "service cloudstack-agent restart" as the host's stored user, without sudo. A host can be added with a non-root user, and LibvirtServerDiscoverer already runs cloudstack-setup-agent with sudo for such a user. The restart then fails with "Interactive authentication required". Prefix the restart with sudo when the user is not root. Signed-off-by: Brad House <bhouse@nexthop.ai>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14741 +/- ##
=========================================
Coverage 18.32% 18.32%
- Complexity 16644 16648 +4
=========================================
Files 5939 5939
Lines 537787 537792 +5
Branches 65932 65933 +1
=========================================
+ Hits 98544 98558 +14
+ Misses 428033 428024 -9
Partials 11210 11210
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR runs the KVM agent restart in
cancelHostMaintenancewithsudowhen the host user is not root.With
kvm.ssh.to.agent=true, cancelling maintenance on a KVM host whose agent is not Up restarts the agent over SSH as the host's stored user. The command had nosudo:LibvirtServerDiscovereralready runssudo cloudstack-setup-agentfor one.Could not restart agent on Host ... Failed to restart cloudstack-agent.service: Interactive authentication required.Fix: new
getAgentRestartCommand(username):rootservice cloudstack-agent restart(unchanged)sudo service cloudstack-agent restartTypes of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
cloudstack, which has NOPASSWD sudo for/usr/sbin/service.ResourceManagerImplTestpasses (74 tests). The mocked host user isuser, so the existing restart tests now expectsudo. NewtestGetAgentRestartCommandcovers root and non-root.server.How did you try to break this feature and the system with this change?
service, which the discoverer already needs forcloudstack-setup-agent.