Repository navigation
kboss: consider kboss.timeout at zone level - #14711
winterhazel wants to merge 1 commit into
Conversation
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14711 +/- ##
=========================================
Coverage 20.78% 20.78%
- Complexity 20857 20859 +2
=========================================
Files 6053 6053
Lines 548230 548238 +8
Branches 73237 73239 +2
=========================================
+ Hits 113928 113934 +6
- Misses 420955 420957 +2
Partials 13347 13347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20074 |
| return backupTimeout.valueIn(host.getDataCenterId()); | ||
| } | ||
|
|
||
| protected Answer sendBackupCommand(long hostId, Command cmd) { |
There was a problem hiding this comment.
Most places where this method is called already have a HostVO reference. It would be best to change the method to receive a HostVO, or receive a zoneId. This way we avoid an extra DB call.
| } | ||
|
|
||
| protected Answer[] sendBackupCommands(Long hostId, Commands cmds) throws OperationTimedoutException, AgentUnavailableException { | ||
| int backupTimeoutValue = getBackupTimeout(hostId); |
Description
Currently, the
kboss.timeoutsetting can be configured at a zone level; however, the code always uses the value configured globally.The code was adjusted to also consider the value configured at zone level. The timeout is now resolved from the zone of the host that will execute the KBOSS command. If the host cannot be found, the global value is used as a fallback.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
kboss.timeoutfor a zone and validated that backups of VMs from that zone were using the zone level value instead of the global value.