Repository navigation
Find wkhtmltopdf without external lookup utilities - #279
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executable discovery currently launches
whichorwhere.exe, so a usablewkhtmltopdfcan still be rejected when the lookup helper is missing. Use Python'sshutil.whichto searchPATHdirectly, including Windows executable extensions, and document that external lookup tools are unnecessary. Explicit paths and the existing installation guidance remain supported.Fixes #259.
Validation: three configuration tests pass on Windows / Python 3.12, covering discovery with helper processes prohibited, a missing executable, and an explicit path with an empty
PATH. The helper-process regression fails before the fix. New tests pass Flake8; the modified source introduces no new diagnostics. Rendering integration tests were not run becausewkhtmltopdfis not installed on this host.Developed and tested with OpenAI Codex assistance.