Skip to content

Find wkhtmltopdf without external lookup utilities - #279

Open
Aschenbath wants to merge 1 commit into
JazzCore:masterfrom
Aschenbath:fix/executable-discovery-259
Open

Aschenbath wants to merge 1 commit into
JazzCore:masterfrom
Aschenbath:fix/executable-discovery-259

Conversation

@Aschenbath

Copy link
Copy Markdown

Executable discovery currently launches which or where.exe, so a usable wkhtmltopdf can still be rejected when the lookup helper is missing. Use Python's shutil.which to search PATH directly, including Windows executable extensions, and document that external lookup tools are unnecessary. Explicit paths and the existing installation guidance remain supported.

Fixes #259.

Validation: three configuration tests pass on Windows / Python 3.12, covering discovery with helper processes prohibited, a missing executable, and an explicit path with an empty PATH. The helper-process regression fails before the fix. New tests pass Flake8; the modified source introduces no new diagnostics. Rendering integration tests were not run because wkhtmltopdf is not installed on this host.

Developed and tested with OpenAI Codex assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hidden dependency on which program

1 participant